jgraph / drawio-desktop

Official electron build of draw.io
https://www.diagrams.net
Apache License 2.0
50.54k stars 5.01k forks source link

Sometimes "save" doesn't work #1857

Open danfloyd111 opened 2 months ago

danfloyd111 commented 2 months ago

Preflight Checklist

Describe the bug Auto-save and manual save through the menu are inconsistent, sometimes they work and sometimes no. The shortcut "cmd+s" always fails without error messages.

To Reproduce Steps to reproduce the behavior:

  1. Do some modifications to an existing schema
  2. Click on 'save' or wait for / trigger the auto-save
  3. Wait for the message "All changes saved" to appear in the menu bar
  4. Quit the application
  5. Open the application again
  6. The modifications are gone like nothing happened

Expected behavior The modifications should be saved, if not possible for some reason an error message should be shown.

draw.io version (In the Help->About menu of the draw.io editor):

Desktop (please complete the following information):

Additional context I'm using exclusively the desktop client, I did not test this functionality on the browser. I switched all the available "themes" but the issue persists. I added the details about my main browser (but I've also other browser installed on my machine).

alderg commented 2 months ago

Where did you save the file?

danfloyd111 commented 2 months ago

Where did you save the file?

In a local folder under my home directory

alderg commented 2 months ago

Is that directory synched with a cloud storage such as Google Drive, OneDrive or Dropbox?

danfloyd111 commented 2 months ago

Is that directory synched with a cloud storage such as Google Drive, OneDrive or Dropbox?

No, it's completely local, no iCloud either. Other than draw.io files, it contains a '.git' file to sync it with a remote repository, but I'm not performing any git ops in between.

I created a new diagram outside that folder, still completely local and without binding this to any git repository: the issue is still here. The auto-save seems more consistent, it works 80% of the times. Saving with cmd+s is not working at all (no messages are shown) while saving through the menu triggers the "all changes are saved" messages but after quitting the application the modifications disappear.

alderg commented 2 months ago

Are you using the desktop version or the web app (in a browser)? Please include all the version information requested in the original issue template.

danfloyd111 commented 2 months ago

Are you using the desktop version or the web app (in a browser)? Please include all the version information requested in the original issue template.

Sorry, I thought I did that by leaving blank the "browser lines". Fixing it now. I'm using the desktop version 24.7.8.

danfloyd111 commented 2 months ago

Edit: I was confused reading "If you delete part/all or miss parts out your issue will be closed." in the instruction, this is the reason why I left some fields not filled. Following the example of other reports, I cleaned the report. Please let me know if now it is ok.

alderg commented 2 months ago

Yes, all good. But it will be difficult to provide any help since you seem to be the only person to have this issue. We'd need more information to help us narrow down the problem. For example, what is the size of the file you are trying to save?

danfloyd111 commented 2 months ago

Yes, all good. But it will be difficult to provide any help since you seem to be the only person to have this issue. We'd need more information to help us narrow down the problem. For example, what is the size of the file you are trying to save?

The file I'm working on is about 30MB, but I was able to reproduce the issue on a new schema created just for testing purposes which is about 4KB.

I can record a video of the issue if it can be helpful. Thanks for your super quick replies!

More info: it doesn't seems to be a "I'm too quick to quit issue". This time I created a test file with a text field and triggered the auto-save feature, then I closed the schema. I opened the schema again and did a quick modification of the text field, then I saved the file through the menu [screenshot 1], then after the "all changes saved" badge appeared on the top I quit the application (cmd+q). After I re-opened the application, the modification I did moments before was gone [screenshot 2]. Hitting cmd+s doesn't even trigger the "all changes saved" badge.

Screenshot 1

Screenshot 2024-09-03 at 16 34 20

Screenshot 2

Screenshot 2024-09-03 at 16 34 33
skaufman commented 2 weeks ago

Seeing same issue with MacOS desktop drawio v24.7.17: manual save and autosave both not working. This is a new issue from earlier versions.