jgraph / drawio-desktop

Official electron build of draw.io
https://www.diagrams.net
Apache License 2.0
51.02k stars 5.04k forks source link

Page size is not passed on the printing #1893

Open FarSeeing opened 1 month ago

FarSeeing commented 1 month ago

Preflight Checklist

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.

Describe the bug The pageSize parameter for the .print call was replaces with the preferCSSPageSize one in 40034f66faf93bd49b1fb22fe6c3b9d0e7100070 The issue is that this preferCSSPageSize is supported in printToPDF method only - https://www.electronjs.org/docs/latest/api/web-contents#contentsprintoptions-callback

To Reproduce Steps to reproduce the behavior:

  1. Set page size to anything but a default A4 one
  2. Print the diagram
  3. The printer settings will get A4 format

Expected behavior Pass page size to the printer

Screenshots If applicable, add screenshots to help explain your problem.

draw.io version (In the Help->About menu of the draw.io editor):

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

m-mohamedin commented 1 month ago

A fix will be in the next release