jgraph / drawio-desktop

Official electron build of draw.io
https://www.diagrams.net
Apache License 2.0
50.75k stars 5.02k forks source link

Request to Add Option to Select Whether Turn On/Off Spell Check #842

Closed zhongxiang117 closed 2 years ago

zhongxiang117 commented 2 years ago

Is your feature request related to a problem? Please describe.

Since the first request to disable spell check was fulfilled, it has been around one year that this useful function is not added back. Why to turn if off only on a "single"(open & close issues) request? The fact is not every is using Mac or the native English speaker. Please take it back or at least add an option to let user make their decision.

Describe the solution you'd like

May it be a good solution to modify UI: image

Describe alternatives you've considered

Or the modification on startup: image

m-mohamedin commented 2 years ago

Will be added to the Extras menu in the next release

zhongxiang117 commented 2 years ago

@ashrafteleb Cool, thank you for your work and consideration!

zhongxiang117 commented 2 years ago

First of all, thanks for your work and consideration for the adding of "Spell checker" option into "Extra" menu starting from v16.1.0.

However, when I tried the new build release v16.1.2 Linux deb version, I found the spell checker does not work even with "Spell checker" turned on.

But, for Windows version, it works very well.

Let me show you the differences;

Linux -- Ubuntu image

Windows 10 image image

My Ubuntu info & dpkg version. image

Could you please take a look into this question? Thanks!

m-mohamedin commented 2 years ago

I think you need to install Hunspell. Electron docs say: "On Windows and Linux this is powered by Hunspell dictionaries, and on macOS it makes use of the native spellchecker APIs."

Could you please try that and let us know?

zhongxiang117 commented 2 years ago

Hi @ashrafteleb, followed your advice, I installed Hunspell, now the spell checker works, thanks!

sandeepshivhare commented 2 years ago

Does spell check gives recommendation on correction? If yes, then how since I am not able to find any option for suggestion.

zhongxiang117 commented 2 years ago

@sandeepshivhare In my experience, no, it does not give spell suggestion, it only shows the indication on whether the word is "valid" or not, which is defined in the dictionary.