jgraph / drawio

draw.io is a JavaScript, client-side editor for general diagramming.
https://www.drawio.com
Apache License 2.0
40.37k stars 7.54k forks source link

Broken dialog - unable to "decide later" when selecting storage #3883

Closed cushyno closed 11 months ago

cushyno commented 11 months ago

Preflight Checklist

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.

If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.

Describe the bug When selecting storage for a new diagram, clicking "Decide later" does not close the modal dialog. Still able to click storage options, but unable to close dialog, therefore unable to use the application without having first selected storage. This means I can't save data to internal browser storage either.

To Reproduce Steps to reproduce the behavior:

  1. Open diagrams.net in new browser window, the "Select a draft to continue editing" dialog is shown.
  2. Click on 'Cancel'
  3. The dialog "Save diagrams to" is shown
  4. Click on 'Decide later'

Expected behavior Expect the dialog to close and present a blank canvas

Screenshots Diagram shows the "Drafts dialog" and "Decide later" link clicked and dialog that has remained on screen afterwards.

Diagrams_net issue - decide later 0 Diagrams_net issue - decide later 1

draw.io version (In the Help->About menu of the draw.io editor):

Desktop (please complete the following information):

Smartphone (please complete the following information): Not applicable

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

Additional context This workflow I have followed for previous 2 years. I use Diagrams.net daily and encourage my colleagues to do so too. This is a serious usability bug for me.

A colleague with same browsers who had v21.7.2 of Diagrams.net was not affected. After clearing cookies and updating to v21.8.2 the same problem is exhibited in his browser too, but only after he has created more than one draft diagram, which is when the initial dialogs show up. Therefore the issue is with closing the dialogs, rather than the underlying application.

cushyno commented 11 months ago

Further info:

Adding URL parameter splash=0 circumvents the dialog closure problem. The drafts dialog still shows, but there is no prompt for which storage to use. No dialog displayed means no issue with "Decide later" link not closing it.

davidjgraph commented 11 months ago

Fix in 22.0.0

cushyno commented 11 months ago

Unfortunately this still seems to be an issue. Testing with same browser versions. Updated to v22.0.0. Ctrl+F5 to refresh page, no dialog issue encountered. F5 (refresh) on its own still exhibits the same symptoms as before, even after performing the Ctrl+F5.

Issue should be re-opened.

davidjgraph commented 11 months ago

OK, but we can no longer repeat it, without being able to recreate on 22.0.0 there's little we can do.

cushyno commented 11 months ago

@davidjgraph, thank you. I'll update if there are any changes to status as a result of browser upgrades or similar at my end.

cushyno commented 11 months ago

My apologies, issue is resolved. I can no longer recreate the issue either. 👍