jgraph / drawio

draw.io is a JavaScript, client-side editor for general diagramming.
https://www.drawio.com
Other
41.3k stars 7.66k forks source link

draw io addons for google workspace have disappeared #4212

Closed Sdayer616 closed 8 months ago

Sdayer616 commented 8 months ago

Preflight Checklist

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.

If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.

Describe the bug A clear and concise description of what the bug is.

The google workspace add-ons for draw.io can not be found anymore (except the one for google drive) Going through drawio.com and down to the links to find the add-ons, the links are all returning an error 400

To Reproduce Steps to reproduce the behavior:

  1. Go to any google doc
  2. Click on Extensions>Add-ons>Get Add-ons
  3. Search for draw.io
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

A possibility to install the Add-on

Screenshots If applicable, add screenshots to help explain your problem. image

draw.io version (In the Help->About menu of the draw.io editor):

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here. The add-ons were available and working last friday (16.02.2024)

DavidRayner commented 8 months ago

I have the same problem. Also, the gsuite.google.com link here taken from this draw.io blog post gives a status 400 error.

davidjgraph commented 8 months ago

We're aware of the issue. It's complex, but the intention would be to create something to replace those.

We cannot give ETAs as replacements would need to go through Google's approval system.

gertverhoog commented 8 months ago

@davidjgraph — thanks for commenting. I've got the same issue. Your reply stating "the intention would be to create something to replace those" and "we cannot give ETAs" make me think this is not going to be working again soon?

I'm writing a Google Doc that I need to get out the door today/tomorrow, but your comment makes it sound like this will take days/weeks/months instead, is that correct? I'll make alternative plans if that's the case.

jeguarnizor commented 8 months ago

Hi @davidjgraph, did you have response about this issue? When we can use draw.io in google docs again?

davidjgraph commented 8 months ago

I will post an update when I have one.

davidjgraph commented 8 months ago

Summary how we got here:

Google asked us to justify having drive.readonly for the draw.io docs, sheets and slides addons. They view that scope as sensitive (and there's certainly a security argument for that). But, we were allowed to use it for 5+ years before that.

They don't like drive.readonly being used as it means the addon can read your entire drive. The scope used in diagrams.net is drive.file, which is access only to files "belonging" to that app, that's the one they want us to use in the addons. We did have a considerable about of comms about it, but the summary from google every time was stop using that scope.

That's fine, just the addons belong to a different google project to the drive integration of diagrams.net. We've had to change the addons to use sidebars in order to support drive.file.

We have the new versions working in testing, just trying to integrate them combined with the existing drive project isn't working (anyone who's used the drive/marketplace cloud console for a while knows what I'm talking about here).

In the meantime, the scopes needs for the addons have been added to the main diagrams.net project. Nobody seems to have been prompted so far. You will need to agree them once the addons are out, but they are all non-sensitive scope permissions now.

Note a side effect of the change is to use a drawio drive file, the file must be assoicated with the drive project. If you create using the desktop app and upload, you won't be able to access it in the addons. The workaround here would be to open it once in app.diagrams.net and save it, that should make the association.

ETA, still don't know. We don't know why we can't link the addons up to the existing project and don't know if there's a google approval process after that. We're hoping no, as the OAuth screen is approved and the scopes are saved, they should be the only things to trigger a review.

davidjgraph commented 8 months ago

We have the addons linked into the main project, but the listing has gone for review to Google.

davidjgraph commented 8 months ago

First version rejected, we used a trademark term without the TM symbol. This is normal, they have to find one thing. But, of course, they haven't told us what the term is or where we used it.

davidjgraph commented 8 months ago

We used (TM) instead of ™, re-submitting.

davidjgraph commented 8 months ago

Rejected, but no indication why, I just re-submitted anyway.

ellulpatrick commented 8 months ago

we're dying out here!

davidjgraph commented 8 months ago

Latest rejection:

Capture d’écran 2024-03-01 à 16 09 28

Our settings:

Capture d’écran 2024-03-01 à 16 06 18

Re-submitted with no changes.

davidjgraph commented 8 months ago

Google now opened a support ticket with us, which I guess is progress.

This was from the google workspace team. They explained that the new implementation to replace the existing doc, sheets and slides (just call that docs for ease) implemenation hurt their systems performance and they had to disable it.

They wanted an explaination as to why we switched from the 3 stand-alone addons to an appscripts addon and asked us to switch it back.

I explained that it was google that decided (after many years) that they wouldn't allow the scope (drive.readonly) used in the docs addons. We had various discussions back and forth, but the conclusion was that we must switch to drive.file as it's much better security-wise (which it is).

We tried using these addons with the project ID of the main google drive integration (671...) and that didn't work. We tried a google workspace implementation on a different project with drive.file. The only solution that worked was an appscript implement on that 671 project ID.

I explained the two options at this point are:

1) The decision to reject the existing apps with drive.readonly scope is reverted. 2) That we get an explanation of why the new implementation is a performance problem and how we can fix that.

We have no idea what the performance issue caused were. The addons are heavily used, so I guess the volume of users took them by surprise.

What they haven't addressed is the repeated rejection of the OAuth section on the 671... project, that shouldn't be related to this.

gabriels-Bizzabo commented 8 months ago

I cant believe that this is happening in the week that I wanted to install the app god dang it GOOGLE!!

davidjgraph commented 8 months ago

Talked with Google today. Friendly chap, but I suspect there's a limited amount that can be done here.

I explained the history of the problem. He explained when we switched the workspace app (replacement for docs, sheets, slides app) on, the volume of queries sent to their systems dealing with workspace appscripts looked like a DoS and they disabled it (along with the draw.io drive marketplace listing (not the app itself). But, badge of honour, we DoSed Google...

Their ETA for looking into why that happened is 3-6 months, so that doesn't help.

They will re-enable the drive app listing (which doesn't help this situation). The docs people still don't like the readonly scope, so we've asked for a 6 month exemption for the addons while alternatives are looked at.

davidjgraph commented 8 months ago

OK, we have docs https://workspace.google.com/marketplace/app/drawio/224440279306 and slides https://workspace.google.com/marketplace/app/drawio_for_slides/588283048931 back. I don't see sheets, but I'm guessing the majority of you wanted docs.

davidjgraph commented 8 months ago

We can't get the main drive app store listing approved, though. They keep repeating this external/production issue, whereas, the app says the settings are correct.

davidjgraph commented 8 months ago

I'll close this up as the docs and slides addons are back. If you need one of the other listings back in the marketplace, please open another ticket.

ergcip commented 8 months ago

Google now opened a support ticket with us, which I guess is progress.

This was from the google workspace team. They explained that the new implementation to replace the existing doc, sheets and slides (just call that docs for ease) implemenation hurt their systems performance and they had to disable it.

They wanted an explaination as to why we switched from the 3 stand-alone addons to an appscripts addon and asked us to switch it back.

I explained that it was google that decided (after many years) that they wouldn't allow the scope (drive.readonly) used in the docs addons. We had various discussions back and forth, but the conclusion was that we must switch to drive.file as it's much better security-wise (which it is).

We tried using these addons with the project ID of the main google drive integration (671...) and that didn't work. We tried a google workspace implementation on a different project with drive.file. The only solution that worked was an appscript implement on that 671 project ID.

I explained the two options at this point are:

  1. The decision to reject the existing apps with drive.readonly scope is reverted.
  2. That we get an explanation of why the new implementation is a performance problem and how we can fix that.

We have no idea what the performance issue caused were. The addons are heavily used, so I guess the volume of users took them by surprise.

What they haven't addressed is the repeated rejection of the OAuth section on the 671... project, that shouldn't be related to this.

Hi what is the best way to be notified when this issue is resolved

davidjgraph commented 8 months ago

@ergcip are you saying the addons still don't show up for you?

ergcip commented 8 months ago

The addon shows up only in drive not directly in google docs

davidjgraph commented 8 months ago

Do you have it installed in docs?

ergcip commented 8 months ago

the addon no longer appears within the market place store checked within our domain and external domain account in gmail.com Screenshot 2024-03-07 130135

ergcip commented 8 months ago

But it does appear within Drive Screenshot 2024-03-07 130312

ergcip commented 8 months ago

Many of our users simply experienced this addon dissapearing from there google docs interface three weeks ago

davidjgraph commented 8 months ago

The listing is there, https://workspace.google.com/marketplace/search/draw.io?host=docs

It might be that it takes some time to update, but the issue of the OP is resolved so this issue is closed. If you still have this or another problem please open a discussion on the topic.

Capture d’écran 2024-03-07 à 20 21 23
ergcip commented 8 months ago

Thank you David I believe we were searching for it but see it now thank you

ergcip commented 8 months ago

The link that you sent helped

Thank you

On Thu, Mar 7, 2024 at 12:48 PM David Benson @.***> wrote:

Do you have it installed in docs?

— Reply to this email directly, view it on GitHub https://github.com/jgraph/drawio/issues/4212#issuecomment-1984309692, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGW4E4VWFKWLFXIJ2VQ5C6LYXDABHAVCNFSM6AAAAABDTIQQ76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUGMYDSNRZGI . You are receiving this because you were mentioned.Message ID: @.***>

-- The contents of this message and any attachment(s) are confidential, proprietary to the City of Edmonton, and are intended only for the addressed recipient. If you have received this in error, please disregard the contents, inform the sender of the misdirection, and remove it from your system. The copying, dissemination, or distribution of this message, if misdirected, is strictly prohibited.

ergcip commented 8 months ago

Hi David the software appears available however we are getting server errors when trying to use

On Thu, Mar 7, 2024 at 1:24 PM David Benson @.***> wrote:

The listing is there, https://workspace.google.com/marketplace/search/draw.io?host=docs

It might be that it takes some time to update, but the issue of the OP is resolved so this issue is closed. If you still have this or another problem please open a discussion https://github.com/jgraph/drawio/discussions on the topic. Capture.d.ecran.2024-03-07.a.20.21.23.png (view on web) https://github.com/jgraph/drawio/assets/1761087/370f0ea8-e1ad-4d84-9eba-d1b9b0d9cb30

— Reply to this email directly, view it on GitHub https://github.com/jgraph/drawio/issues/4212#issuecomment-1984361943, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGW4E4QUHVBNOJ6YGPKE4CTYXDEGFAVCNFSM6AAAAABDTIQQ76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUGM3DCOJUGM . You are receiving this because you were mentioned.Message ID: @.***>

-- The contents of this message and any attachment(s) are confidential, proprietary to the City of Edmonton, and are intended only for the addressed recipient. If you have received this in error, please disregard the contents, inform the sender of the misdirection, and remove it from your system. The copying, dissemination, or distribution of this message, if misdirected, is strictly prohibited.

ergcip commented 8 months ago

missed one attachment [image: image.png]

On Thu, Mar 7, 2024 at 2:26 PM Ergun Ciplak @.***> wrote:

Hi David the software appears available however we are getting server errors when trying to use

On Thu, Mar 7, 2024 at 1:24 PM David Benson @.***> wrote:

The listing is there, https://workspace.google.com/marketplace/search/draw.io?host=docs

It might be that it takes some time to update, but the issue of the OP is resolved so this issue is closed. If you still have this or another problem please open a discussion https://github.com/jgraph/drawio/discussions on the topic. Capture.d.ecran.2024-03-07.a.20.21.23.png (view on web) https://github.com/jgraph/drawio/assets/1761087/370f0ea8-e1ad-4d84-9eba-d1b9b0d9cb30

— Reply to this email directly, view it on GitHub https://github.com/jgraph/drawio/issues/4212#issuecomment-1984361943, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGW4E4QUHVBNOJ6YGPKE4CTYXDEGFAVCNFSM6AAAAABDTIQQ76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUGM3DCOJUGM . You are receiving this because you were mentioned.Message ID: @.***>

-- The contents of this message and any attachment(s) are confidential, proprietary to the City of Edmonton, and are intended only for the addressed recipient. If you have received this in error, please disregard the contents, inform the sender of the misdirection, and remove it from your system. The copying, dissemination, or distribution of this message, if misdirected, is strictly prohibited.

davidjgraph commented 8 months ago

The issue that started this ticket is resolved, if you have a further issue please open a discussion or issue on that.

strowk commented 8 months ago

Hey, I believe that the issue is not actually resolved. You have mentioned above

I'll close this up as the docs and slides addons are back

Unfortunately slides addon is NOT back (it is present in marketplace but not installable, which is not exactly "back", is it?):

image

Could you reopen this? There appears to be a mistake somewhere still.

If this is as intended - addon is there, but cannot be installed, I believe this makes situation worse - as people spend time to attempt to get it, while it actually does not work, so the net is sort of negative. You have to jump (IMO) one particular way - either addon present and works, or it is not there at all and documentation updated to note that. F.e this is currently misleading.

Standing in the middle like this - "we have app, here is how to install it, .. hour later: unfortunately because of Google, it won't work" is kind of the worst of possible evils :)

davidjgraph commented 8 months ago

It would be up to the OP to request a re-open, but I'm not going to at this point. You are welcome to open a new issue.

dazraf commented 1 month ago

I've tried a few times but it definitely is blocked. Please can you re-open this ticket? Thank you.

image