jgrawrock
commented
7 years ago Thanks for the review!
I'll do further reading on the id/class combos and using them more effectively. My biggest question here, would be on the comments. On this type of project what types of comments would you expect to see here?
ad3429
Summary Grade: Satisfactory; needs additional fixes
Good job! Your files are organized nicely, and you did a great job of following the client specification -- this is an important skill to have as a developer and you seem to understand that. Moreover, you generally followed good code practice, so make sure to keep that up!
I have made some comments in your code to take note of. First off, it seems that you incorrectly linked to your CSS file by linking to a local file on your computer. This will cause trouble with rendering your CSS on other people's computer. Check your code comments for a corrected way of linking your CSS. Moreover, in future projects make sure to comment the main parts of your code (both your HTML and CSS). This will greatly help your development flow, especially as your projects get larger and more complex. Here is a quick refresher on commenting in HTML and CSS, respectively:
Next off, rather than giving your paint, brushes and frames elements classes, you should instead assign them ID's since they are unique, individual elements. You usually use class when you want to give a group of elements the same styling. Here is a great resource that explains the difference between class and ID:
https://css-tricks.com/the-difference-between-id-and-class/
Good job overall! As a further challenge, try using css to design your webpage even further! You did a great job in following the client specification, but for your own practice you should see how creative you can get by taking the design/styling of your site to the next level (for example, you can try experimenting with background colors on your other divs).