jgrazulis / mod_0_assessment

0 stars 0 forks source link

Assessment Results #1

Open mschae16 opened 3 years ago

mschae16 commented 3 years ago

@jgrazulis - Hi Jessica, I just finished reviewing your assessment and there are a few changes that I’d like for you to make before I consider you technical ready. Please have them done by EOD Tuesday and send me a slack message once completed.

Let me know if you have any questions about the above.

mschae16 commented 3 years ago

@jgrazulis - Updates are looking really good! You are officially technical ready. One note on your variables.rb updates - I noticed you wrote out the entire value of the movie string and added .size to it - since that string value is captured in your movie variable, an easier to way to print the length is as follows - print movie.length or print movie.size. Additionally, I noticed you commented on your height and keys in your models with #inches or #lbs - another option here, is to add it to the variable name - for example, you could name them respectively: height_in_inches or weight_in_lbs. Let me know if you have any questions and keep up the great work!