search

jgreco / mpv-youtube-quality

A userscript for MPV that allows you to change youtube video quality (ytdl-format) on the fly
370 stars 36 forks source link

Not all quality choices visible if there are too many #5

Open ctlaltdefeat opened 5 years ago

ctlaltdefeat commented 5 years ago

If videos have many different quality options, it may happen that not all quality choices are visible on screen. I'm not sure if/how it may be possible to deal with this.

JonnyHaystack commented 5 years ago

I have the same problem. The text for the quality options seems to vary depending on the current resolution of the currently playing video? When I open a video and it's in 4k, I see only very few options because the text is huge. The options are clearly still there as I can navigate down through them with the arrow keys but I can't see what I'm selecting. After lowering the resolution to 1080p, the text is a lot smaller and I can see a lot more of the options.

jgreco commented 5 years ago

The global mpv options osd-font-size and osd-scale-by-window and the mpv-youtube-quality option scale_playlist_by_window can be used to change how mpv does font size at different resolutions, though it might take a bit of fiddling around to find a configuration you like.

Improving this so mpv-youtube-quality measures the size of the window and the text, so it can create a nice scrolling menu that fills the available space correctly is on my roadmap, but I haven't laid down any code for it yet.

JonnyHaystack commented 5 years ago

Ok, by setting osd-font-size I can make the font always a reasonable size, and osd-scale-by-window=no helps too I think but haven't tested it that much. However, I've realised that there's a bigger issue. When the video first loads, the quality menu appears separately from the video, but if I set the quality to something lower, say 480p then it's as though the menu becomes part of the video, and it won't go back to the normal size/position even if I change the quality back to what it was before. Before: img-2019-05-27-387 After: img-2019-05-27-391

I'm guessing the way your script works is that it creates a new mpv window within the first one or something like that? Because after changing the quality, my screenshot tool shows me that they are two different windows.

Bogdan107 commented 2 years ago

I have the same problem: list with all availabled formats are not fully visibled. I resolve problem by changing:

style_ass_tags={\\fnmonospace\\fs40\\bord1}

in youtube-quality.conf