search

jgreene / slimtune

Automatically exported from code.google.com/p/slimtune
MIT License
0 stars 0 forks source link

Function Details graph shows wrong data #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The graph shown does not represent the actual underlying information. 
Attached is an example shown in Function Details and corresponding Tree 
Graph.

The data in Tree Graph seems to be correct and corresponds to raw dump 
from SELECT * FROM Callers WHERE CallerId = 2527 which returns

    1   2527    0   39
    1   2527    2417    3
    1   2527    2470    1
    1   2527    2535    3
    1   2527    2536    1
    1   2527    2540    15
    1   2527    2541    6
    1   2527    2545    1
    1   2527    2547    1
    5   2527    0   4292
    5   2527    1746    20
    5   2527    2417    184
    5   2527    2470    28
    5   2527    2535    381
    5   2527    2536    6
    5   2527    2540    2447
    5   2527    2541    248
    5   2527    2699    192
    5   2527    2719    10
    5   2527    2742    11
    5   2527    2795    1
    5   2527    2800    4
    5   2527    2823    7
    5   2527    2442    11
    5   2527    2545    6
    5   2527    2815    9
    5   2527    2829    2
    5   2527    2890    5
    5   2527    2547    9
    5   2527    2933    2
    5   2527    2952    1
    5   2527    2959    3
    5   2527    2975    2
    5   2527    2980    3
    5   2527    2858    1
    5   2527    3017    1

From this data it's clear that time spent in self should be much higher 
than what is represented in the graph.

The issue appears to be

const string kInFunctionQuery = @" 
 SELECT HitCount 
 FROM Callers 
 WHERE CallerId = {0} AND CalleeId = 0 
 "; 

which should have SUM(HitCount) instead.

Original issue reported on code.google.com by kavanpro...@gmail.com on 25 Feb 2010 at 10:21

Attachments:

GoogleCodeExporter commented 9 years ago 
Yeah, this was an oversight of the fact that the callers table is broken apart 
by
thread. Will fix in next rev.

Original comment by promit....@gmail.com on 25 Feb 2010 at 10:25

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r185.

Original comment by promit....@gmail.com on 27 Feb 2010 at 5:46