jgrodziski / metav

Release and Versioning of Clojure projects using tools.deps
Eclipse Public License 1.0
68 stars 12 forks source link

Module name override #1

Closed mhuebert closed 5 years ago

mhuebert commented 5 years ago

Thanks for this project! I am interested in using it to publish a ClojureScript lib to clojars. In my case I have a dedicated repo (say, my-lib) which should be published to Clojars under a namespace, eg. my-org/my-lib. In the readme I saw a mention of an override for the module name, which might allow me to do this:

Module's name is by default deduced from the repo path layout (but can also be overriden)

However I didn't see any other mention of this override in the readme or in my (brief) look at the source. I was wondering if I was missing something, or if you have any suggestions as to how to accomplish this. Thanks!

jgrodziski commented 5 years ago

Hi Matt, You're right, the module-name override is pending...my bad. I was just waiting for this issue to pop-up :) I should take some time this weekend to implement it. For consistency, the --module-name CLI option override should be present for the three tasks (artifact-name, spit and release).

jgrodziski commented 5 years ago

Hi Matt, I've pushed the module name override feature in a dedicated branch, the test suite ran successfully but I didn't have time to test it thoroughly through the CLI. You can test it on your side with the commit "cb493428ffe23de0a7f6e76511ba718a7217e1a2". The new CLI option for all three tasks is: "-r" "--module-name-override MODULE-NAME"

mhuebert commented 5 years ago

Thanks @jgrodziski! I tried it locally and it appears to work correctly for me.

jgrodziski commented 5 years ago

the module-name override feature was added in version 1.2.0. README updated accordingly