[SX126x][SX128x][LR11x0] Don't report CRC mismatch if valid header received

jgromes / RadioLib

Universal wireless communication library for embedded devices

https://jgromes.github.io/RadioLib/

MIT License

1.52k stars 381 forks source link

[SX126x][SX128x][LR11x0] Don't report CRC mismatch if valid header received #1203

Closed GUVWAF closed 1 month ago

GUVWAF commented 1 month ago

Fixes #1202.

Tested this based on #1190 already using an SX1262 radio. I was able to catch a packet where indeed the HEADER_ERR IRQ was set, but also HEADER_VALID and the payload CRC was OK, and the payload could be decrypted and parsed successfully.

StevenCellist commented 1 month ago

Nope, the LoRaWAN stack doesn't touch any Header IRQ, so good to go.

jgromes commented 1 month ago

Merged - @GUVWAF thank you for another contribution, it is greatly appreciated!

GUVWAF commented 1 month ago

Also thanks to you both for the quick review!