Regional Parameters Typo in "LoRaWAN: Device setup on TTN" Wiki

jgromes / RadioLib

Universal wireless communication library for embedded devices

https://jgromes.github.io/RadioLib/

MIT License

1.59k stars 399 forks source link

Regional Parameters Typo in "LoRaWAN: Device setup on TTN" Wiki #1334

Closed Zep0 closed 6 days ago

Zep0 commented 6 days ago

Hi, there is a newer version of the equivalent note, where the revision number of the regional parameters is fixed.

Instead of:

RadioLib uses Regional Parameters 1.1 revision 1.1.

it now says:

RadioLib uses RP001 Regional Parameters 1.1 revision A.

Source: https://github.com/jgromes/RadioLib/wiki/LoRaWAN:-Device-setup-on-TTN https://github.com/jgromes/RadioLib/blob/master/examples/LoRaWAN/LoRaWAN_Starter/notes.md

jgromes commented 6 days ago

@StevenCellist which one of these is correct? Just for the sake of consistence ;)

StevenCellist commented 6 days ago

Talking about consistency.... this is a proper mess. But at least I'll make these two match each other.

StevenCellist commented 6 days ago

Actually, upon further inspection, I added a slight modification such that RadioLib properly corresponds to 1.1 revision B instead of revision A. All mentions in this repository have been updated to reflect this change, although it's practically identical to revision A.