search

jgromes / RadioLib

Universal wireless communication library for embedded devices
https://jgromes.github.io/RadioLib/
MIT License
1.41k stars 356 forks source link

[SX1276] Request to add setCrcFiltering(bool crcOn = true) #524

Closed matthias-bs closed 2 years ago

matthias-bs commented 2 years ago

For my application, I have to disable CRC filtering in FSK packet mode.

As a workaround, I changed SX127x.cpp as follows: In SX127x::configFSK(): state = _mod->SPIsetRegValue(RADIOLIB_SX127X_REG_PACKET_CONFIG_1,[...] | RADIOLIB_SX127X_CRC_ON | [...], 7, 0); replaced by state = _mod->SPIsetRegValue(RADIOLIB_SX127X_REG_PACKET_CONFIG_1,[...] | RADIOLIB_SX127X_CRC_OFF | [...], 7, 0);

The CC1101 module has a function setCrcFiltering(bool crcOn) for this purpose. It would be great if the SX127x had the same function.

matthias-bs commented 2 years ago

Added proposed solution: Pull request [SX1276] Request to add setCrcFiltering()

matthias-bs commented 2 years ago

Added proposed solution: Pull request [SX127x] added setCrcFiltering() (This time changed from a fresh fork. =:-) )

jgromes commented 2 years ago

Resolved by merging #527.

matthias-bs commented 2 years ago

Thanks a lot!