jgrossi / elephpant.me

🐘 a simple website to help you to trade elePHPants 💥
https://elephpant.me
MIT License
63 stars 30 forks source link

limit country list to active countries #185

Closed JonPurvis closed 1 year ago

JonPurvis commented 1 year ago

This PR tackles one of the points in https://github.com/jgrossi/elephpant.me/pull/107, but does it a different way.

At the moment, the application uses the same list of countries throughout. On the rankings page, for example, it shows all 257 countries when in reality, only a small number of those countries currently return any results. This PR provides an alternate way of getting a relevant countries list, depending on the page in question.

There's 2 pages that remain unchanged:

These 2 pages still show all 257 countries. However, if you're on the Rankings page, it will only show countries that have a user, so on my local version, I see this:

image

Which is much easier to navigate!