fix(trading): add missing parameter country

pgrimaud commented 8 months ago

👋 Hello there!

Long time no see...

We have a fatal error on those 2 routes:

/trade/senders/{elephpantId}
/trade/receivers/{elephpantId}

ErrorException
Undefined variable: country (View: /Users/pgrimaud/workspace/oss/elephpant.me/resources/views/trade/index.blade.php)
http://127.0.0.1:8000/trade/receivers/1

teiling88 commented 8 months ago

and deployed - thank you for your contribution :-)

pgrimaud commented 8 months ago

Great! Have you issues about performance? I saw very high latency on some pages. 😰

Pierre Grimaud IT Consulting / Web Development / Software Engineering +33 6 85 18 30 37 https://p.ier.re https://github.com/pgrimaud

On Fri, 22 Dec 2023 at 11:59 PM, Thomas Eiling @.***> wrote:

and deployed - thank you for your contribution :-)

— Reply to this email directly, view it on GitHub https://github.com/jgrossi/elephpant.me/pull/194#issuecomment-1868118679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOHWAGY55LMFKI5JRPDXJTYKYGEVAVCNFSM6AAAAABBAANVEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGEYTQNRXHE . You are receiving this because you authored the thread.Message ID: @.***>

teiling88 commented 8 months ago

Yes there are some performance impacts cause of the used Models there. Will fix it after my vacation :-)

I saw your profile, are you interested in a trade? One Symfony 10 Years Elephpant for an PHPartner? :D

pgrimaud commented 8 months ago

@teiling88 I'm sorry bro. The Symfony 10 Years Elephpant, is so rare (500 specimens only). I keep it for a "special" trade. 😞

jgrossi / elephpant.me

fix(trading): add missing parameter country #194