search

jgrss / geowombat

GeoWombat: Utilities for geospatial data
https://geowombat.readthedocs.io
MIT License
184 stars 10 forks source link

geowombat v1.11.4 breaks conda #188

Closed mmann1123 closed 2 years ago

mmann1123 commented 2 years ago

Just got this report back from the conda feedstock or for details go here

Assuming pinning the xarray version pulls the older rasterio - breaking things downstream? What do you think @jgrss 

The reported errors are:
- Encountered problems while solving:
-   - package rasterio-1.0.23-py27h5b3f9e8_0 requires libgdal >=2.4.1,<2.5.0a0, but none of the providers can be installed
-   - package pyproj-1.9.4-py27_0 requires python 2.7*, but none of the providers can be installed
jgrss commented 2 years ago

Hmm, geowombat==1.11.4 pulls a higher version of rasterio than v1.0.23. I just did a fresh installation from main and it installed rasterio==1.3.2. Is conda free to build any version of rasterio in the build? I don't see a version requirement for it.

mmann1123 commented 2 years ago

Yeah I don't pin any versions in the feedstock and it should be able to pull whatever solves all requirements. So not sure... Instead of pinning xarray could we just implement the np.max min as suggested in #186? (although that seemed to open other issues possibly)

jgrss commented 2 years ago

Can you see if this is still an issue after #189?

mmann1123 commented 2 years ago

Ok looks like it builds 2.0 fine on everything but python 3.7. regardless of OS. Should we pin python >=3.8

Looks like opencv is the issue.

mmann1123 commented 2 years ago

@jgrss I think finally step is to pin python 3.8 or greater

jgrss commented 2 years ago

See #200

jgrss commented 2 years ago

200 is merged into main so let me know how the conda build goes.

mmann1123 commented 2 years ago

After much futzing I figured out that adding the skip line to meta.yml in the feedstock would allow us to avoid building in py3.7. Should be merging soon.

build:
  number: 0
  skip: true  # [py<38]
  script: {{ PYTHON }} setup.py build && pip install .
mmann1123 commented 2 years ago

Resolved! @jgrss new conda build should be available in a few hours

mmann1123 commented 1 year ago

I just approved the python version pin. I will let you squash it

On Wed, Sep 14, 2022 at 10:15 AM Jordan Graesser @.***> wrote:

See #200 https://github.com/jgrss/geowombat/pull/200

— Reply to this email directly, view it on GitHub https://github.com/jgrss/geowombat/issues/188#issuecomment-1246831770, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHR6VGH4RPX56V6HFTIYZLV6HMZ5ANCNFSM6AAAAAAQBSX7QY . You are receiving this because you were assigned.Message ID: @.***>

jgrss commented 1 year ago

This is closed from ~month ago. Is this correct?

mmann1123 commented 1 year ago

Yep this is resolved

On Tue, Oct 11, 2022 at 9:26 AM Jordan Graesser @.***> wrote:

This is closed from ~month ago. Is this correct?

— Reply to this email directly, view it on GitHub https://github.com/jgrss/geowombat/issues/188#issuecomment-1274684837, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHR6VDFZMGRCVI4OJTUPE3WCVTHXANCNFSM6AAAAAAQBSX7QY . You are receiving this because you modified the open/close state.Message ID: @.***>