search

jgrss / geowombat

GeoWombat: Utilities for geospatial data
https://geowombat.readthedocs.io
MIT License
182 stars 10 forks source link

Requirement differences between package & conda-forge #280

Closed DManowitz closed 1 year ago

DManowitz commented 1 year ago

According to the setup.cfg file for v.2.1.10, the numpy dependency is numpy>=1.19.0. However, on conda-forge, the numpy dependency is numpy>=1.24.4. Do you know why this is?

jgrss commented 1 year ago

Thanks for raising this. I don't know why conda-forge is pinning a higher version (@mmann1123). However, we can do some testing to see if we can either raise numpy in the github repo or lower numpy in conda-forge.

DManowitz commented 1 year ago

If you can keep the lower numpy bound and figure how to get it to work correctly on conda-forge, that would be much appreciated.

DManowitz commented 1 year ago

According to meta.yaml in the geowombat conda-forge feedstock, under run, it has {{ pin_compatible('numpy') }}. According to this file, it looks like that should correspond to numpy >=1.21. However, if the most recent version of geowombat actually works with numpy >=1.19.0, perhaps the run section of the meta.yaml file in the geowombat conda-forge feedstock should just have numpy >=1.19.0.

jgrss commented 1 year ago

I agree, unless we have a specific reason for increasing the numpy version then I think we should leave it at >=1.19.0 to give users more flexibility.

I increased the lower version to >=1.24.4 in #281 to test it. However, @mmann1123 let us know if you can pin numpy to >=1.19.0 in the conda build.

mmann1123 commented 1 year ago

@jgrss Looks like pinning 1.19 to conda will work fine. I just pushed the changes. I think we can close this. https://github.com/conda-forge/geowombat-feedstock/pull/103

jgrss commented 1 year ago

@DManowitz I am going to close this but please reopen if the problem persists.