jgrss / geowombat

GeoWombat: Utilities for geospatial data
https://geowombat.readthedocs.io
MIT License
182 stars 10 forks source link

fix: adding random forest classifier test which breaks #301

Closed mmann1123 closed 3 months ago

mmann1123 commented 4 months ago

I identified an untested bug in geowombat. Basically sklearn-xarray needs scikit-learn=1.2.0 or it breaks with forest estimators. Adding test and trying to limit scikit version in setup.cfg for ml add-on install. had to set scikit-learn to 1.2.0 to fix the issue

What is this PR changing?

Add a description

Checklist

Tag options:

Example:

fix: <branch name> PR number
mmann1123 commented 3 months ago

@jgrss after a bit of mussing about this is ready to look at

mmann1123 commented 3 months ago

@jgrss I am not sure what the "Tests - waiting for status to be reported" is. What's the plan for merging here?

jgrss commented 3 months ago

@jgrss I am not sure what the "Tests - waiting for status to be reported" is. What's the plan for merging here?

I can merge it.

fergrc89 commented 3 months ago

thanks for fixing this!