jgrygierek / BatchEntityImportBundle

Importing entities with preview and edit features for Symfony.
MIT License
9 stars 6 forks source link

Fix MatrixRecord bug with accepting objects as data value #86

Closed a-afsharfarnia closed 11 months ago

a-afsharfarnia commented 11 months ago

Description

In the recent update to MatrixRecord, type hints were introduced to enhance code readability and maintainability (PR #77).

However, there's an opportunity to refine the type hinting for the $value parameter. Currently, it is specified as null|string|int, but in practice, it can take on a broader range of types, such as objects, booleans, etc. This becomes particularly relevant when utilizing EntityType in our import configuration, where the field type may necessitate an object value. The current solution limits this flexibility.

Steps to Test

  1. Create an import configuration with an EntityType field.
  2. Verify that the import process will be done successfully with the specified field.

Related Issues or Pull Requests

jgrygierek commented 11 months ago

Hi @a-afsharfarnia can you fix tests (missing package)?

a-afsharfarnia commented 11 months ago

Hi @a-afsharfarnia can you fix tests (missing package)?

Done

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ced7917) 97.07% compared to head (537aa39) 97.07%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #86 +/- ## ========================================= Coverage 97.07% 97.07% Complexity 179 179 ========================================= Files 29 29 Lines 478 478 ========================================= Hits 464 464 Misses 14 14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jgrygierek commented 11 months ago

@a-afsharfarnia can you change line 3 in .github/workflows/code_style.yml? It should be on: [ push, pull_request ], because now code style tests are frozen.

a-afsharfarnia commented 11 months ago

@a-afsharfarnia can you change line 3 in .github/workflows/code_style.yml? It should be on: [ push, pull_request ], because now code style tests are frozen.

Done