Closed a-afsharfarnia closed 11 months ago
Hi @a-afsharfarnia can you fix tests (missing package)?
Hi @a-afsharfarnia can you fix tests (missing package)?
Done
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ced7917
) 97.07% compared to head (537aa39
) 97.07%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@a-afsharfarnia can you change line 3 in .github/workflows/code_style.yml
? It should be on: [ push, pull_request ]
, because now code style tests are frozen.
@a-afsharfarnia can you change line 3 in
.github/workflows/code_style.yml
? It should beon: [ push, pull_request ]
, because now code style tests are frozen.
Done
Description
In the recent update to
MatrixRecord
, type hints were introduced to enhance code readability and maintainability (PR #77).However, there's an opportunity to refine the type hinting for the
$value
parameter. Currently, it is specified asnull|string|int
, but in practice, it can take on a broader range of types, such as objects, booleans, etc. This becomes particularly relevant when utilizingEntityType
in our import configuration, where the field type may necessitate an object value. The current solution limits this flexibility.Steps to Test
EntityType
field.Related Issues or Pull Requests