jgte29 / team-ernst-engel-proj03

0 stars 0 forks source link

Hazel Kirk Code Review #1

Open amandaneslund opened 4 months ago

amandaneslund commented 4 months ago

Code review Ernst Engel

Your guys project looks it off to a solid start. Below are a couple of things I noticed.

-I liked the counterfactual experiment of modifying food prices, but I think it would elevate your project if you did a second counterfactual. Changing food prices is interesting but I think it would be beneficial for your project to dive a little deeper.

-Add coding for household with an unknown region was really smart way to clean the data you had.

-All of the descriptions of the inputs and outputs of your code made it really easy and clear to understand as viewer. It may be helpful to add a table of contents at the top of your code as well.

-The description of “def get_counts” and “def_get_diet_adequies” are the same. I think this just a problem in the description labeling otherwise having both seems redundant, if both code are putting the household counts into a panda data frame.

-I like the display of the nutrition with the highest average shares, but I think it would be insightful to include the lowest average shares and median too.

-The interactivity development part of your code is super impress and I think it goes above and beyond to make your project really strong.

-I would love to see more about Tanzania specifically in your presentation. I think it would be beneficial to add more counterfactual experiments or visuals from your data that explain why the state of nutrition is specific to the conditions in Tanzania. Maybe including things like the climate or income of different homes verses different regions could be interesting to explore.

Overall the project looks super interesting and its evident how much time and detail went into creating all the code so far. There is definitely more details or counterfactuals you could add to go above and beyond, but I think your group project is really solid so far. Super interested by your topic and I can’t wait to see your final presentation!

wusamantha commented 4 months ago

Thank you for your insights and suggestions. We will look into implementing some of them!!