jgthms / bulma

Modern CSS framework based on Flexbox
https://bulma.io
MIT License
49.27k stars 3.95k forks source link

Active dropdown item not being styled differently #3337

Open dosena opened 3 years ago

dosena commented 3 years ago

This is about the Docs (possibly also about the css framework itself, but the docs confuse me here)

Overview of the problem

This is about the Bulma Docs I'm using Bulma version 0.9.2 My browser is: Safari 14.1 or Firefox 88.0.1 (macOS Mojave)

Description

Getting the "active" dropdown-item to display differently is not described very clearly if at all in the docs.

In the very first example, you can see the 3rd item "Active dropdown item" with a nice blue background. I want this behavior!

You have to dig into the matching HTML to figure out that it's got the is-active class.

A further problem or question pops up then: I am using <div> for the dropdown items; the docs mention you should use this or <a>. But the stylesheet rule currently used on your site only has the selector a.dropdown-item.is-active, button.dropdown-item.is-active.

Am I supposed to make my own stylesheet rule matching div.dropdown-item.is-active? Or is this something bulma should provide?

dareksob commented 2 years ago

I this should be wrong. because button nodes not work as dropdown-item. This looks as a bug

dareksob commented 2 years ago

quick fix for scss context

div.dropdown-item.is-active {
  background-color: $dropdown-item-active-background-color;
  color: $dropdown-item-active-color;
}