search

jgthms / bulma

Modern CSS framework based on Flexbox
https://bulma.io
MIT License
49.22k stars 3.95k forks source link

Forms > tools .icon should be child combinator #3699

Closed langsys closed 10 months ago

langsys commented 10 months ago

This is about Bulma. I consider it a bug.

Overview of the problem

This is about the Bulma CSS framework I'm using Bulma version 0.9.4

.control.has-icons-left|right .icon is overreaching, .icon should not match all descendants.

The bulma docs indicate the form field icon should be implemented with a span.icon as a direct child of the .control, but the css matches any descendant. This can be a problem if you are using a different icon system that also requires its element to have the class icon.

Proposal

Forms .control.has-icons-left .icon should be .control.has-icons-left > .icon

So long as people have implemented according to docs, this minor change should have no negative side-effects.

Fix in saas sass/form/tools.saas (line 183) 

- 183 | .icon
+ 183 | >.icon
langsys commented 10 months ago

sorry you can delete this issue, opened via pull requests instead in case you wanted it