SASS deprecations of red(), green(), blue()

scarytom commented 1 month ago

This is about Bulma.

Overview of the problem

This is about the Bulma CSS framework I'm using Bulma version 1.0.2 My browser is: chrome This is a Sass issue: I'm using version 1.79.2

Description

Recently, I have been getting deprecation warnings when compiling Bulma. These are a result of breaking changes in Sass, where they are soon to remove the color functions red(), green(), and blue().

Steps to Reproduce

npx sass bulma.scss

Expected behavior

no deprecation warnings

Actual behavior

Deprecation Warning: red() is deprecated. Suggestion:

color.channel($color, red, $space: rgb)

More info: https://sass-lang.com/d/color-functions

   ╷
99 │     "red": red($color),
   │            ^^^^^^^^^^^
   ╵
    node_modules/bulma/sass/utilities/functions.scss 99:12          bulmaColorLuminance()
    node_modules/bulma/sass/utilities/functions.scss 128:7          bulmaFindColorInvert()
    node_modules/bulma/sass/utilities/derived-variables.scss 16:15  @forward
    node_modules/bulma/sass/utilities/_index.scss 6:1               @use
    bulma.scss 11:1                                                 @use

jgthms commented 1 month ago

Yes this comes from the sass package but there is currently a bug: https://github.com/sass/dart-sass/issues/2353

So I'm just waiting for this to be merged so I can update sass to the latest version.

ghiscoding commented 1 month ago

Yes this comes from the sass package but there is currently a bug: sass/dart-sass#2353

So I'm just waiting for this to be merged so I can update sass to the latest version.

That was released in v1.79.2 and there's even v1.79.3 that came out afterward, so it should be a good time to update now :)

Side note and for more visibility, I think this issue should be renamed as "SASS deprecations of red, green, ...."

minusf commented 1 month ago

Doesn't seem to be fixed atm:

% ./node_modules/.bin/sass --version
1.79.3 compiled with dart2js 3.5.3

% npm run build_css
> sass --load-path=node_modules bulma-mss.scss static/style.css

Deprecation Warning: red() is deprecated. Suggestion:

color.channel($color, "red", $space: rgb)

More info: https://sass-lang.com/d/color-functions

   ╷
99 │     "red": red($color),
   │            ^^^^^^^^^^^
   ╵
    node_modules/bulma/sass/utilities/functions.scss 99:12          bulmaColorLuminance()
    node_modules/bulma/sass/utilities/functions.scss 128:7          bulmaFindColorInvert()
    node_modules/bulma/sass/utilities/derived-variables.scss 16:15  @forward
    node_modules/bulma/sass/utilities/_index.scss 6:1               @forward
    bulma/_index.scss 1:1                                           @use
    bulma-mss.scss 9:1                                              root stylesheet

scarytom commented 1 month ago

@jgthms can I just check: is this issue blocked on anything any more?

If it is now just a matter of bumping the SASS version and refactoring red() into color.channel($color, "red", $space: rgb) and similarly for green and blue then I might be able to make you a pull request.

ohabash commented 1 week ago

sass: 1.80.6 compiled with dart2js 3.5.4

"bulma-scss": "^0.9.4",
"react": "18.3.1",

How do i fix?

jgthms commented 1 week ago

@jgthms can I just check: is this issue blocked on anything any more?

If it is now just a matter of bumping the SASS version and refactoring red() into color.channel($color, "red", $space: rgb) and similarly for green and blue then I might be able to make you a pull request.

Basically I tried bumping up the Sass version to the latest one and refactoring the Bulma code but that was throwing other errors, hence the wait.

I'll check if Sass has released a newer version.

jgthms / bulma