jgthms / bulma

Modern CSS framework based on Flexbox
https://bulma.io
MIT License
49.16k stars 3.95k forks source link

has-shadow doesn't work as in the past or expected #892

Closed roni-estein closed 7 years ago

roni-estein commented 7 years ago

Overview of the problem

This is about the Bulma CSS framework This is about the Bulma Docs (possibly) I'm using Bulma version 0.4.3 My browser is: chrome Version 59.0.3071.115 (Official Build) (64-bit) On MacOS Sierra

I am sure this issue is not a duplicate?

Description

On both nav.nav and nav.navbar has-shadow produces nothing. If you add the css manually nothing happens either.

Steps to Reproduce

.1 take an example bulma menu, add class has-shadow

here is a fiddle https://jsfiddle.net/roni_estein/y3Lvwbz0/12/

Expected behavior

I'd expect it to continue to work as in earlier versions. A shadow separator under the nav element

Actual behavior

No shadow under the nav element

jgthms commented 7 years ago

879

roni-estein commented 7 years ago

I don't know enough to tell you if this is the same issue or not. But the use case is different. This isn't being adapted into a site or template. This is me getting to know bulma and using an example right out of your docs with no other CSS in play and the result is different than the expected or displayed result.

Rather than saying there is a work around, I'd update the docs or fix the issue. If this IS expected behaviour deprecate has-shadow. I'd venture that not being able to use box-shadow on a nav or div is pretty odd for an expected behavior.

Adding

html {width: 100%; height: 100%} body {width: 100%; height: 100%}

Is not a hard fix, but maybe add that to the docs. Does it impact anything else? If not why not adapt it into the bulma base CSS?