jguhlin / minimap2-rs

Rust bindings to minimap2 library
Other
63 stars 13 forks source link

Use &Path instead of &str for index. #20

Closed ahcm closed 1 year ago

ahcm commented 1 year ago

What do you think? Will only work on Unix though.

jguhlin commented 1 year ago

How about AsRef?

ahcm commented 1 year ago

Even better.

codecov[bot] commented 1 year ago

Codecov Report

Merging #20 (37337aa) into main (28674ea) will decrease coverage by 0.09%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   40.26%   40.17%   -0.09%     
==========================================
  Files           3        3              
  Lines         668      667       -1     
==========================================
- Hits          269      268       -1     
  Misses        399      399              
Impacted Files Coverage Δ
src/lib.rs 60.00% <100.00%> (-0.14%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.