search

jguhlin / minimap2-rs

Rust bindings to minimap2 library
Other
51 stars 11 forks source link

Add support for compiling aarch64 targets and resolve #30 #44

Closed leiste375 closed 11 months ago

leiste375 commented 11 months ago

Hi

As promised, the necessary changes. Neon should now be automatically included, plus a couple of flags that were necessary.

Tested both with and without simde and htslib.

Greetings

jguhlin commented 11 months ago

Hey, this is awesome! Thanks for helping out. I'll get this merged in next week and push out a release soon.

leiste375 commented 11 months ago

I've noted that the test with mm2-fast fails. However it also fails when cross-compiling to x86-64, and compilation of mm2-fast itself fails as well, both with and without aarch64 and neon. I will see what I can do from my end, but will treat it as a separate issue if that's ok with you.

jguhlin commented 11 months ago

That'd be great, but mm2-fast is falling behind compared to the newest version of minimap2, so definitely don't stress. I'll make a comparability matrix with architectures and features.

On Fri, 18 Aug 2023, 7:33 pm leiste375, @.***> wrote:

I've noted that the test with mm2-fast fails. However it also fails when cross-compiling to x86-64, and compilation of mm2-fast itself fails as well, both with and without aarch64 and neon. I will see what I can do from my end, but will treat it as a separate issue if that's ok with you.

— Reply to this email directly, view it on GitHub https://github.com/jguhlin/minimap2-rs/pull/44#issuecomment-1683490851, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOA2CEDU7WNGODUWPWJRC3XV4LEJANCNFSM6AAAAAA3T6EWU4 . You are receiving this because you commented.Message ID: @.***>