jguhlin / minimap2-rs

Rust bindings to minimap2 library
Other
51 stars 11 forks source link

Cross compilation compatibility builds #46

Closed Adoni5 closed 10 months ago

Adoni5 commented 10 months ago

Main changes

Other changes

  1. For linux aarch64, for some reason to cross compile, the C99 standard had to be enabled, due to for loop constructions in minimap2. I've added this to the simde feature function, https://github.com/Adoni5/minimap2-rs/blob/d804692362e414058123de21d3464f6e7d615f52/minimap2-sys/build.rs#L167 But I don't know if that's the best place to put it?

  2. I added fakeminimap2 and minimap2-sys as cargo workspaces in the root Cargo.toml, simply so that rust-analyzer would work in the directory. This can be removed if you prefer, but I don't think it has any knock on effects otherwise.

  3. Built fakeminimap2 with local minimap2-rs crate - no reason, just seems semi-logical as it seems useful for testing.

Adoni5 commented 10 months ago

Final note - the Cargo.toml for minimap2-rs currently points to the local minimap2-sys. This should be updated when the new version of minimap2-sys is up on crates.io

jguhlin commented 10 months ago

Amazin!. I'm recovering from a conference but will get this pushed out in the next few days.