Mark bam::Record objects as supplementary.

jguhlin / minimap2-rs

Rust bindings to minimap2 library

Other

51 stars 11 forks source link

Mark bam::Record objects as supplementary. #52

Closed PB-DB closed 4 months ago

PB-DB commented 4 months ago

Hi - thanks for a fabulous crate!

I'm aiming to use this to generate valid htslib BAM records.

Marking them as supplementary/secondary would be a big help, and this seems to work, but I have not generated tests.

jguhlin commented 4 months ago

Both PR's merged in. I've got another bug or two to address, and then going to update to today's newest minimap2 release (excellent timing!) and push out a release.

PB-DB commented 4 months ago

Sounds great!

If it's not much extra work, it would be convenient if some of the functions taking &Vec<_> parameters could be tweaked to take &[_] instead while you're working on it, but up to you!

Thanks again for this crate; it's a solid workhorse.

jguhlin commented 4 months ago

Going to try, I've definitely improved my FFI skills since last time. There may be a slight performance penalty though (generics, then still have to copy each Vec to convert to a nul terminated C string).