search

jguhlin / minimap2-rs

Rust bindings to minimap2 library
Other
63 stars 13 forks source link

Only use rust-htslib/curl when `curl` feature is enabled. #53

Closed PB-DB closed 6 months ago

PB-DB commented 7 months ago

rust-htslib is pulling in curl by default; this PR disables default features on rust-htslib and enables curl only if curl is selected as a feature of this crate.

It's pretty minor, but libcurl can be a tough dependency to manage.

Behavior should remain unchanged unless a user opts out by disabling default features for minimap2-rs.

jguhlin commented 7 months ago

Nice! I actually prefer trimming the dep tree wherever we can. I'm afraid I won't get a chance to look at these and merge until next week, just FYI.