jguhlin / minimap2-rs

Rust bindings to minimap2 library
Other
60 stars 13 forks source link

question for drop, send and sync trait for a similar rust wrapper hmmer-rs #62

Open jianshu93 opened 1 month ago

jianshu93 commented 1 month ago

Dear @jguhlin,

I really think the minimap2-rs is something big and bring mappers to rust. In a similarly wrapper around another widely used software hmmer, hmmer-rs (https://github.com/wwood/hmmer-rs), I think the FFI is not perfect, e.g., send & sync trait are not implemented (https://github.com/wwood/hmmer-rs/blob/main/src/hmm.rs) , therefore it cannot be use in a parallel settings. I am not an expert on FFI but think it should be obvious for you to add a little bit more, then we will have hmm in Rust!

Let me know your thoughts on this.

Thanks,

Best,

Jianshu