jguhlin / minimap2-rs

Rust bindings to minimap2 library
Other
60 stars 13 forks source link

fix: cigar string missing softclip operation #74

Closed Sam-Sims closed 3 weeks ago

Sam-Sims commented 3 weeks ago

PR addresses a bug in the CIGAR string formatting where soft-clipping (S) at the start of a CIGAR string was concatenated in the wrong order, so any softclipped bases at the start of the CIGAR were being incorrectly added as an integer to the next operation (#73)

Minimap2: 3S11232M9D10

Before: cigar_str: Some("311232M9D10")

After: cigar_str: Some("3S11232M9D10")

Tested this against a hard copy of minimap2 + cargo test

Let me know what you think

Cheers

jguhlin commented 3 weeks ago

Easy as, thanks!