search

jguhlin / minimap2-rs

Rust bindings to minimap2 library
Other
60 stars 13 forks source link

Better detection of supplementary alignments #76

Closed rob-p closed 3 weeks ago

rob-p commented 3 weeks ago

This is related to issue 72. Essentially, minimap2-rs is treating secondary alignments as supplementary, whereas they are quite different.

Unfortunately, the code where the supplementary alignment flag is set in minimap2 isn't super-elegant, I believe the most relevant part is here. I've made this change in this PR and it seems to work in my use case. Note that I'm not handling the > 1 segment case here, so I believe we'll need further work to handle reads with > 1 segment (e.g. paired-end short reads).

jguhlin commented 3 weeks ago

Cool. I'll dig into this today. Paired-end reads aren't supported yet, but it'll be good to make a note here for in the future