search

jgx65 / hierfstat

the hierfstat package
24 stars 14 forks source link

allow data with subset of nucleotides to be processed #11

Closed zkamvar closed 8 years ago

zkamvar commented 8 years ago

Data sets that only represent a subset of nucleotides (eg A, C, T, but not G) are currently rejected. This was discovered in https://github.com/NESCent/popgenInfo/pull/87#issuecomment-165166528

I've changed identical(alleles.name, nucleotides) to all(alleles.name %in% nucleotides)

jgx65 commented 8 years ago

@zkamvar BTW, would you agree on being added to the author list of hierfstat? Cheers

zkamvar commented 8 years ago

Sure!

I would suggest to list me as a "contributor" as opposed to "author" since I've added a few bug fixes, but that's up to your philosophy on authorship :smiley:

jgx65 commented 8 years ago

Done.