search

jhaals / ansible-vault

ansible lookup plugin for secrets stored in Vault(by HashiCorp)
BSD 3-Clause "New" or "Revised" License
347 stars 65 forks source link

Feature/no context #21

Closed richfromm closed 7 years ago

richfromm commented 8 years ago

This builds upon the previous pull request: https://github.com/jhaals/ansible-vault/pull/20

It relaxes the Python >= 2.7.9 requirement, in that it now works in earlier versions if you are not using an SSL context.

I'm not sure of the etiquette of cumulative pull requests. Is it confusing that this is a superset of the previous pull request? Should I have held off with the previous request and submitted all of these changes as a single pull request? Please let me know if you'd like me to do things differently in the future.

richfromm commented 7 years ago

I can redo this once other outstanding pull requests are complete, but it appears to me that it's not possible in github to create separate pull requests that are truly separate (and not including the preceding commits) if there are open dependent pull requests.

richfromm commented 7 years ago

Replaced by #26