search

jhaals / ansible-vault

ansible lookup plugin for secrets stored in Vault(by HashiCorp)
BSD 3-Clause "New" or "Revised" License
347 stars 65 forks source link

Feature/dot vault token file #22

Closed richfromm closed 7 years ago

richfromm commented 8 years ago

I only really meant this pull request to be these changes:

But it is cummulatively showing both this, as well as my previous two (still outstanding) pull requests:

Apologies if I'm not handling this well. My familiarity with github is limited; I'm used to just using straight up git.

Anyway, the base for this idea is the main part of this previous rejected pull request:

I kept the part reading the token from the file if present and the env var is not set. I incorporated the suggestions about handling IOError, updating the error message, and ensuring the file is closed.

I explicitly did not set the SSL protocol version in the context options. First, I am not using homebrew, so I have no way of either duplicating whatever problem might exist, or testing a fix. Second, this page notes "Deprecated since version 2.7.13: OpenSSL has deprecated all version specific protocols. Use the default protocol with flags like OP_NO_SSLv3 instead."

richfromm commented 7 years ago

Replacing this with #25, which properly only includes the one commit I want.

sidick commented 7 years ago

Just a comment, the best way to create PRs is to always create your local branch by forking from the current master, that way they are all independant. Does make it awkward when some things depend on others though...