jhalterman / expiringmap

A high performance thread-safe map that expires entries
Apache License 2.0
1k stars 142 forks source link

Don't ignore unhandled exceptions #65

Closed xxDark closed 4 years ago

jhalterman commented 4 years ago

I'm actually fine ignoring these exceptions since they're coming from a user's code and there's nothing ExpiringMap can do to handle them other than pass them back to the user. In which case users can make sure their code handles exceptions if they want to.

Also, FWIW, Guava doesn't pass these to uncaught exception handler in it's RemovalListener :) https://github.com/google/guava/blob/master/guava/src/com/google/common/cache/LocalCache.java#L1812