search

jhalterman / lyra

High availability RabbitMQ client
Apache License 2.0
262 stars 74 forks source link

Enhancement: add onUnrecoverable() and onUnretryable() methods to listeners #42

Closed spatula75 closed 9 years ago

spatula75 commented 10 years ago

It would be nice if, in the event that Lyra will not attempt a recovery / retry (e.g., if the exception thrown is not among the recoverable/retryable exceptions), we could get a callback in the Channel, Consumer, and/or Connection listeners so that if there is specific program logic we wish to perform in the event of an unrecoverable failure, we can run it. Otherwise it can be hard to discern from the client library side of things whether a recovery is in progress, or things are never going to recover.

It might also be nice to have an onRecoveryStarted hook so internal checks in the app (eg, for health polling) can take recovery into consideration.

jhalterman commented 10 years ago

Let me know what you think of the listener changes and I'll cut a new release if they look good. A description of the changes is in the changelog.

jhalterman commented 9 years ago

Lyra 0.5.0 has been released with these changes.

spatula75 commented 9 years ago

Sorry I didn't get back to you faster. The changes look good, and we're working on updating to use 0.5.0!

On 8 December 2014 at 11:23, Jonathan Halterman notifications@github.com wrote:

Lyra 0.5.0 has been released with these changes.

— Reply to this email directly or view it on GitHub https://github.com/jhalterman/lyra/issues/42#issuecomment-66170430.

"Courage isn't just a matter of not being frightened, you know. It's being afraid and doing what you have to do anyway." -- Doctor Who - Planet of the Daleks This message has been brought to you by Nick Johnson 2.3b1 and the number 6.