search

jhalterman / lyra

High availability RabbitMQ client
Apache License 2.0
263 stars 74 forks source link

OSGi support #63

Closed saksmt closed 8 years ago

jhalterman commented 8 years ago

The classloader change looks good.

For the manifest, how about generating the manifest via the maven bundle plugin? That way any code changes in the future will be automatically picked up.

saksmt commented 8 years ago

@jhalterman, OK, I'll add it in a moment. I've just thought that new dependencies isn't good decision.

jhalterman commented 8 years ago

The bundle plugin is cool with me since it's just a build dependency.

jhalterman commented 8 years ago

Oh, one more thing I noticed. We need to keep the original Connections.create(ConnectionOptions, Config) method for backwards compatibility. It can just call the new Connections.create(ConnectionOptions, Config, ClassLoader) method.

saksmt commented 8 years ago

Forgot about this overload.

jhalterman commented 8 years ago

Thanks!

jhalterman commented 8 years ago

0.5.3 is released with this change. It should be in central in an hour or so.

saksmt commented 8 years ago

Thanks for quick approval! Now need to remove hack from my production code :smile: