search

jhalterman / lyra

High availability RabbitMQ client
Apache License 2.0
263 stars 74 forks source link

support withUri() in ConnectionOptions #69

Closed neuhaus closed 7 years ago

neuhaus commented 7 years ago

Feature request:

The rabbitmq java client supports factory.setUri(), in order to switch to lyra I have to add quite a bit of extra code because it doesn't support URIs.

Please add support for URIs to ConnectionOptions

jhalterman commented 7 years ago

Care to send a pull request for this?

neuhaus commented 7 years ago

Given that getAdresses tries to use ConnectionOptions host value first and then falls back to factory.getHost this seems to be easy.

Actually I noticed that I will need something like setURIs() which is not so easy currently: It is mandatory that only the host changes among the URIs, not the port, virtualhost etc.

neuhaus commented 7 years ago

Please let me know what you think. I will not actually use this, I will use withHosts() myself.

neuhaus commented 7 years ago

Added pull request #70

jhalterman commented 7 years ago

This looks good - thanks!