jhalterman / lyra

High availability RabbitMQ client
Apache License 2.0
263 stars 74 forks source link

Add support for NIO that added in rabbit client 4.x #72

Closed igreenfield closed 7 years ago

michaelklishin commented 7 years ago

@jhalterman this looks like a useful and low risk improvement. 👍 from team RabbitMQ.

jhalterman commented 7 years ago

@igreenfield Thanks a lot for this. Also thanks to @michaelklishin for giving it a look.

Before I merge, are there any test cases that make sense to include with these commits?

igreenfield commented 7 years ago

@jhalterman I don't see any test needed.

jhalterman commented 7 years ago

Thanks again for this!

igreenfield commented 7 years ago

@jhalterman When you will release version with this?

jhalterman commented 7 years ago

Just released 0.5.4 that includes this. It should be in central shortly...