proposed changes for "Lyra recover mechanism prevent from the JVM to shutdown"

jhalterman / lyra

High availability RabbitMQ client

Apache License 2.0

262 stars 74 forks source link

proposed changes for "Lyra recover mechanism prevent from the JVM to shutdown" #81

Closed DimaGolomozy closed 7 years ago

DimaGolomozy commented 7 years ago

I've changed NamedThreadFactory to create daemon threads, so that the JVM won't hang if the executor is not shutdown state.

The recovery is manged by Lyra, so I've disabled the automaticRecovery flag in the ConectionFactory

DimaGolomozy commented 7 years ago

@jhalterman any thoughts?

michaelklishin commented 7 years ago

@acogoluegnes and I don't think it's a good idea. It should not be necessary to force daemon threads if all resources are released correctly (as it is not necessary in the Java client, for example).

We should introduce a new property and keep the default instead of forcing this on everyone. Please look into a new PR and provide a way to reproduce the non-terminating JVM case.

The disabling automatic recovery for RabbitMQ Java client part was addressed in #82.