search

jhamlet / svg-react-loader

Webpack SVG to React Component Loader
MIT License
559 stars 82 forks source link

Fix classIdPrefix with interpolation #107

Open woutervanvliet opened 6 years ago

woutervanvliet commented 6 years ago

Fixes #94

woutervanvliet commented 6 years ago

I'm not all too familiar with the should library, and didn't manage to find out how to write tests with it that check if some string includes something else - within reasonable time. So my tests contain simple throw statements.

If you can tell me how to write them to better match the rest of the test structure I'd be happy to update this PR.

woutervanvliet commented 6 years ago

@jhamlet I've converted the check to be a positive assertion

jhamlet commented 5 years ago

Thanks for the PR.

Will merge over the weekend.

;-j

woutervanvliet commented 5 years ago

@jhamlet ping ;)

Would you be able to merge?

antonyoneill commented 5 years ago

Bump.. @jhamlet

slonofanya commented 5 years ago

Could you merge it please? @jhamlet

slonofanya commented 5 years ago

@woutervanvliet ?

nakamarusun commented 2 years ago

Bump