search

jhamlet / svg-react-loader

Webpack SVG to React Component Loader
MIT License
559 stars 82 forks source link

Remove unused props assignment #41

Closed teameh closed 8 years ago

teameh commented 8 years ago

Props is assigned here but immediately reassigned on line 41. This was introduced here: https://github.com/jhamlet/svg-react-loader/commit/1103a029ef09ad74303949e8432a20a982d6e8c7#diff-168726dbe96b3ce427e7fedce31bb0bcR57

I think this line can be removed since after changing the tag, the assignment with assign after the conditional is always correct :)

tera-sinube commented 8 years ago

See my comments in issue #40