Fix react deprecation warnings

jhamlet / svg-react-loader

Webpack SVG to React Component Loader

MIT License

559 stars 82 forks source link

Fix react deprecation warnings #67

Closed konstantin24121 closed 7 years ago

konstantin24121 commented 7 years ago

Add create-react-class into dependencies and change in template

Issue: #66

Andarist commented 7 years ago

next step would also be to migrate this to es6 classes, right?

konstantin24121 commented 7 years ago

I'm not sure that is big difference there, but it can extend from PureComponent. @Andarist what did you think?

Andarist commented 7 years ago

There are 2 differences - one u have mentioned (but aint sure if we should incorporate, it would break actual semantics now) and second which is - es6 classes are the preferred way for creating class components now and dont need extra dependency of create-react-class - most ppl use babel anyway.

create-react-class was kept only so the migration path is easier and even deprecation warning has mentioned this

konstantin24121 commented 7 years ago

I agree with you, but this question must be resolved with maintainer

tomasztomys commented 7 years ago

Please release new version of loader.

jessy1092 commented 7 years ago

@jhamlet I use this PR on my own project. It works perfectly. It would be useful if official release include this feature.

srosset81 commented 7 years ago

Any news on this ? The React deprecation warnings are really annoying...