search

jhamlet / svg-react-loader

Webpack SVG to React Component Loader
MIT License
559 stars 82 forks source link

handle file names with dots property #71

Closed jessy1092 closed 7 years ago

jessy1092 commented 7 years ago

For issue #49

Let the title-case method can work with dots. It would translate minus.inline.svg to MinusInline

[update 1]: Add todo list

jhamlet commented 7 years ago

@jessy1092 Thanks for the pull request.

Can you add a test in test/unit/utility/title-case.js too?

For extra credit, do you think you can add this as an option to the loader titleCaseDelim=[RegExp]?

Thanks,

;-j

jessy1092 commented 7 years ago

@jhamlet OK, I will try it. 👍

jessy1092 commented 7 years ago

@jhamlet I finish the feature. Please review. :)

jhamlet commented 7 years ago

Quick glance: looks good.

I will review deeper later this evening.

Thanks, ;-j