search

jhanley634 / dojo-blackboard

An HTMX webserver for the Dojo's Tuesday night python meetups.
MIT License
3 stars 1 forks source link

42-unit-registry #43

Closed jhanley634 closed 2 weeks ago

jhanley634 commented 2 weeks ago

Summary by Sourcery

Bug Fixes:

sourcery-ai[bot] commented 2 weeks ago

Reviewer's Guide by Sourcery

This PR makes minor adjustments to time-related constant declarations and assertions in the database utility module. The changes focus on improving type checking and making the assertions more precise.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Refine time constant declarations and assertions
  • Remove explicit type annotation for _one_day variable
  • Add runtime type check to ensure _one_day is a Quantity instance
  • Update MINUTES_PER_DAY assertion to use integer comparison instead of float
 src/bboard/util/database.py

Possibly linked issues

Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).