jhanley634 / dojo-blackboard

An HTMX webserver for the Dojo's Tuesday night python meetups.
MIT License
3 stars 1 forks source link

7 transit map #8

Closed jhanley634 closed 2 months ago

jhanley634 commented 2 months ago

Summary by Sourcery

Add new features to track and display the ISS's location and implement a clock display with 1 Hz updates. Enhance the build system with a new coverage target and improve type safety across the codebase. Introduce tests for the new features and mechanisms to ensure reliability and correctness.

New Features:

Enhancements:

Build:

Tests:

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request implements several new features and improvements to the existing codebase, including the addition of an International Space Station (ISS) tracking system, a clock display, and various code quality and testing enhancements.

File-Level Changes

Change Details Files
Implemented ISS tracking and visualization
  • Added functions to fetch and store ISS position data
  • Created a world map visualization of ISS location
  • Implemented database models and sessions for ISS position data
src/bboard/main.py
src/bboard/transit/iss.py
src/bboard/models/iss_position.py
src/bboard/database.py
tests/iss_test.py
Added clock display functionality
  • Implemented clock display HTML generation
  • Created endpoints for clock display and value
  • Added pub/sub mechanism for clock updates
src/bboard/main.py
src/bboard/demo/clock_display.py
src/bboard/transit/pub_sub/clock_pub.py
src/bboard/transit/pub_sub/clock_sub.py
tests/clock_display_test.py
Enhanced build and test processes
  • Updated Makefile with new targets and improved coverage reporting
  • Added new test cases for ISS tracking, clock display, and web utilities
  • Implemented type checking improvements and mypy configurations
Makefile
tests/iss_test.py
tests/clock_display_test.py
tests/web_test.py
src/bboard/util/credentials.py
src/bboard/util/fs.py
Improved code quality and security
  • Enhanced error handling and type annotations
  • Implemented better security practices for handling credentials
  • Refactored and optimized existing code
src/bboard/util/credential_env_vars.py
src/bboard/util/credentials.py
src/bboard/util/fs.py
src/bboard/transit/vehicles.py
src/bboard/util/requests.py

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.