jharmison-redhat / openshift-devsecops

The merger of the CI/CD demos, provisioning, and DevSecOps workshop content into a single repo, built on OCP 4.x
17 stars 15 forks source link

Operator fixes, Tekton guides #54

Closed akochnev closed 4 years ago

akochnev commented 4 years ago

This is a cumulative PR of the last few sets of changes, all rolled in one:

One thing to note is that there is a timing issue with the OpenShift pipelines operator which makes the devsecops playbook fail the first time (as the operator takes a bit of time to provision the pipeline service account), which makes the playbook fail the first time. Running it a second time goes through.

andykrohg commented 4 years ago

I suggested a few mods in a PR to your branch https://github.com/akochnev/openshift-devsecops/pull/1: I've also built an image with your new guides in case you want to see the feel in the workshop-dashboard. Just set workshop_dashboard_image: quay.io/akrohg/devsecops-workshop-dashboard-tekton:latest in the workshop-spawner role's vars.

We'll need to add tkn to the workshop terminal as well - I'll create a separate issue and tackle that in the meantime

akochnev commented 4 years ago

@andykrohg - good stuff. I accepted your PR in my branch, so this PR has the cumulative changes.

jharmison-redhat commented 4 years ago

One small fixup for CRW/Keycloak deployment objects which I'll commit after. Otherwise, LGTM!