search

jharmison-redhat / openshift-devsecops

The merger of the CI/CD demos, provisioning, and DevSecOps workshop content into a single repo, built on OCP 4.x
17 stars 15 forks source link

LetsEncrypt has become confusing for RHPDS users #70

Closed jharmison-redhat closed 4 years ago

jharmison-redhat commented 4 years ago

The old LetsEncrypt toggle for Quay specifically was just on whether or not there were AWS keys exported or included. Now it's entirely off of the feature flag toggle, and that makes it confusing for some users who weren't including this toggle in their variables and aren't rebuilding their variable files to match the examples often.

I think that, if LetsEncrypt is on but AWS keys aren't present, we should emit a warning and continue on without LetsEncrypt.

andykrohg commented 4 years ago

Your approach seems sounds to me 👍