search

jharris4 / html-webpack-tags-plugin

lets you define html tags to inject with html-webpack-plugin
MIT License
255 stars 31 forks source link

Fix Ignoring public path option when path is a http or file url #28

Closed ElvisKang closed 6 years ago

ElvisKang commented 6 years ago

27

jharris4 commented 6 years ago

Thanks for this PR but as explained in this comment you can already ignore/disable the publicPath via the publicPath option to the plugin constructor.

I've added an example to the publicPath test to show that this works:

plugins: [
          new HtmlWebpackPlugin(),
          new HtmlWebpackIncludeAssetsPlugin(
            { assets: 'local-with-public-path.js', append: false, publicPath: true }
          ),
          new HtmlWebpackIncludeAssetsPlugin(
            { assets: ['local-without-public-path.js', 'http://www.foo.com/foobar.js'], append: false, publicPath: false }
          )
        ]